change proxy_test

proxy/proxy_test.go

@@ -41,6 +41,82 @@ func testSendRequest(t *testing.T, endpoint string, client *http.Client, bodyWan
 	}
 }
 
+type testProxyHelper struct {
+	server    *http.Server
+	proxyAddr string
+
+	ln                     net.Listener
+	tlsPlainLn             net.Listener
+	tlsLn                  net.Listener
+	httpEndpoint           string
+	httpsEndpoint          string
+	testOrderAddonInstance *testOrderAddon
+	testProxy              *Proxy
+	getProxyClient         func() *http.Client
+}
+
+func (helper *testProxyHelper) init(t *testing.T) {
+	t.Helper()
+
+	mux := http.NewServeMux()
+	mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
+		w.Write([]byte("ok"))
+	})
+	helper.server.Handler = mux
+
+	// start http server
+	ln, err := net.Listen("tcp", "127.0.0.1:0")
+	handleError(t, err)
+	helper.ln = ln
+
+	// start https server
+	tlsPlainLn, err := net.Listen("tcp", "127.0.0.1:0")
+	handleError(t, err)
+	helper.tlsPlainLn = tlsPlainLn
+	ca, err := cert.NewCAMemory()
+	handleError(t, err)
+	cert, err := ca.GetCert("localhost")
+	handleError(t, err)
+	tlsConfig := &tls.Config{
+		Certificates: []tls.Certificate{*cert},
+	}
+	helper.tlsLn = tls.NewListener(tlsPlainLn, tlsConfig)
+
+	httpEndpoint := "http://" + ln.Addr().String() + "/"
+	httpsPort := tlsPlainLn.Addr().(*net.TCPAddr).Port
+	httpsEndpoint := "https://localhost:" + strconv.Itoa(httpsPort) + "/"
+	helper.httpEndpoint = httpEndpoint
+	helper.httpsEndpoint = httpsEndpoint
+
+	// start proxy
+	testProxy, err := NewProxy(&Options{
+		Addr:        helper.proxyAddr, // some random port
+		SslInsecure: true,
+	})
+	handleError(t, err)
+	testProxy.AddAddon(&interceptAddon{})
+	testOrderAddonInstance := &testOrderAddon{
+		orders: make([]string, 0),
+	}
+	testProxy.AddAddon(testOrderAddonInstance)
+	helper.testOrderAddonInstance = testOrderAddonInstance
+	helper.testProxy = testProxy
+
+	getProxyClient := func() *http.Client {
+		return &http.Client{
+			Transport: &http.Transport{
+				TLSClientConfig: &tls.Config{
+					InsecureSkipVerify: true,
+				},
+				Proxy: func(r *http.Request) (*url.URL, error) {
+					return url.Parse("http://127.0.0.1" + helper.proxyAddr)
+				},
+			},
+		}
+	}
+	helper.getProxyClient = getProxyClient
+}
+
 // addon for test intercept
 type interceptAddon struct {
 	BaseAddon
@@ -172,32 +248,22 @@ func (addon *testOrderAddon) StreamResponseModifier(f *Flow, in io.Reader) io.Re
 }
 
 func TestProxy(t *testing.T) {
-	// start http server
+	helper := &testProxyHelper{
-	ln, err := net.Listen("tcp", "127.0.0.1:0")
+		server:    &http.Server{},
-	handleError(t, err)
+		proxyAddr: ":29080",
-	defer ln.Close()
-	go http.Serve(ln, nil)
-
-	// start https server
-	tlsLn, err := net.Listen("tcp", "127.0.0.1:0")
-	handleError(t, err)
-	defer tlsLn.Close()
-	ca, err := cert.NewCAMemory()
-	handleError(t, err)
-	cert, err := ca.GetCert("localhost")
-	handleError(t, err)
-	tlsConfig := &tls.Config{
-		Certificates: []tls.Certificate{*cert},
 	}
-	go http.Serve(tls.NewListener(tlsLn, tlsConfig), nil)
+	helper.init(t)
-
+	httpEndpoint := helper.httpEndpoint
-	http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
+	httpsEndpoint := helper.httpsEndpoint
-		w.Write([]byte("ok"))
+	testOrderAddonInstance := helper.testOrderAddonInstance
-	})
+	testProxy := helper.testProxy
-
+	getProxyClient := helper.getProxyClient
-	httpEndpoint := "http://" + ln.Addr().String() + "/"
+	defer helper.ln.Close()
-	httpsPort := tlsLn.Addr().(*net.TCPAddr).Port
+	go helper.server.Serve(helper.ln)
-	httpsEndpoint := "https://localhost:" + strconv.Itoa(httpsPort) + "/"
+	defer helper.tlsPlainLn.Close()
+	go helper.server.Serve(helper.tlsLn)
+	go testProxy.Start()
+	time.Sleep(time.Millisecond * 10) // wait for test proxy startup
 
 	t.Run("test http server", func(t *testing.T) {
 		testSendRequest(t, httpEndpoint, nil, "ok")
@@ -226,33 +292,6 @@ func TestProxy(t *testing.T) {
 		})
 	})
 
-	// start proxy
-	testProxy, err := NewProxy(&Options{
-		Addr:        ":29080", // some random port
-		SslInsecure: true,
-	})
-	handleError(t, err)
-	testProxy.AddAddon(&interceptAddon{})
-	testOrderAddonInstance := &testOrderAddon{
-		orders: make([]string, 0),
-	}
-	testProxy.AddAddon(testOrderAddonInstance)
-	go testProxy.Start()
-	time.Sleep(time.Millisecond * 10) // wait for test proxy startup
-
-	getProxyClient := func() *http.Client {
-		return &http.Client{
-			Transport: &http.Transport{
-				TLSClientConfig: &tls.Config{
-					InsecureSkipVerify: true,
-				},
-				Proxy: func(r *http.Request) (*url.URL, error) {
-					return url.Parse("http://127.0.0.1:29080")
-				},
-			},
-		}
-	}
-
 	t.Run("test proxy", func(t *testing.T) {
 		proxyClient := getProxyClient()
 
@@ -385,65 +424,25 @@ func TestProxy(t *testing.T) {
 }
 
 func TestProxyWhenServerNotKeepAlive(t *testing.T) {
-	mux := http.NewServeMux()
+	server := &http.Server{}
-	mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
-		w.Write([]byte("ok"))
-	})
-	server := &http.Server{
-		Handler: mux,
-	}
 	server.SetKeepAlivesEnabled(false)
-
+	helper := &testProxyHelper{
-	// start http server
+		server:    server,
-	ln, err := net.Listen("tcp", "127.0.0.1:0")
+		proxyAddr: ":29081",
-	handleError(t, err)
-	defer ln.Close()
-	go server.Serve(ln)
-
-	// start https server
-	tlsLn, err := net.Listen("tcp", "127.0.0.1:0")
-	handleError(t, err)
-	defer tlsLn.Close()
-	ca, err := cert.NewCAMemory()
-	handleError(t, err)
-	cert, err := ca.GetCert("localhost")
-	handleError(t, err)
-	tlsConfig := &tls.Config{
-		Certificates: []tls.Certificate{*cert},
-	}
-	go server.Serve(tls.NewListener(tlsLn, tlsConfig))
-
-	httpEndpoint := "http://" + ln.Addr().String() + "/"
-	httpsPort := tlsLn.Addr().(*net.TCPAddr).Port
-	httpsEndpoint := "https://localhost:" + strconv.Itoa(httpsPort) + "/"
-
-	// start proxy
-	testProxy, err := NewProxy(&Options{
-		Addr:        ":29081", // some random port
-		SslInsecure: true,
-	})
-	handleError(t, err)
-	testProxy.AddAddon(&interceptAddon{})
-	testOrderAddonInstance := &testOrderAddon{
-		orders: make([]string, 0),
 	}
-	testProxy.AddAddon(testOrderAddonInstance)
+	helper.init(t)
+	httpEndpoint := helper.httpEndpoint
+	httpsEndpoint := helper.httpsEndpoint
+	testOrderAddonInstance := helper.testOrderAddonInstance
+	testProxy := helper.testProxy
+	getProxyClient := helper.getProxyClient
+	defer helper.ln.Close()
+	go helper.server.Serve(helper.ln)
+	defer helper.tlsPlainLn.Close()
+	go helper.server.Serve(helper.tlsLn)
 	go testProxy.Start()
 	time.Sleep(time.Millisecond * 10) // wait for test proxy startup
 
-	getProxyClient := func() *http.Client {
-		return &http.Client{
-			Transport: &http.Transport{
-				TLSClientConfig: &tls.Config{
-					InsecureSkipVerify: true,
-				},
-				Proxy: func(r *http.Request) (*url.URL, error) {
-					return url.Parse("http://127.0.0.1:29081")
-				},
-			},
-		}
-	}
-
 	t.Run("should not have eof error when server side DisableKeepAlives", func(t *testing.T) {
 		proxyClient := getProxyClient()
 		t.Run("http", func(t *testing.T) {
@@ -484,65 +483,25 @@ func TestProxyWhenServerNotKeepAlive(t *testing.T) {
 }
 
 func TestProxyWhenServerKeepAliveButCloseImmediately(t *testing.T) {
-	mux := http.NewServeMux()
+	helper := &testProxyHelper{
-	mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
+		server: &http.Server{
-		w.Write([]byte("ok"))
+			IdleTimeout: time.Millisecond * 10,
-	})
+		},
-	server := &http.Server{
+		proxyAddr: ":29082",
-		Handler:     mux,
-		IdleTimeout: time.Millisecond * 10,
 	}
-
+	helper.init(t)
-	// start http server
+	httpEndpoint := helper.httpEndpoint
-	ln, err := net.Listen("tcp", "127.0.0.1:0")
+	httpsEndpoint := helper.httpsEndpoint
-	handleError(t, err)
+	testOrderAddonInstance := helper.testOrderAddonInstance
-	defer ln.Close()
+	testProxy := helper.testProxy
-	go server.Serve(ln)
+	getProxyClient := helper.getProxyClient
-
+	defer helper.ln.Close()
-	// start https server
+	go helper.server.Serve(helper.ln)
-	tlsLn, err := net.Listen("tcp", "127.0.0.1:0")
+	defer helper.tlsPlainLn.Close()
-	handleError(t, err)
+	go helper.server.Serve(helper.tlsLn)
-	defer tlsLn.Close()
-	ca, err := cert.NewCAMemory()
-	handleError(t, err)
-	cert, err := ca.GetCert("localhost")
-	handleError(t, err)
-	tlsConfig := &tls.Config{
-		Certificates: []tls.Certificate{*cert},
-	}
-	go server.Serve(tls.NewListener(tlsLn, tlsConfig))
-
-	httpEndpoint := "http://" + ln.Addr().String() + "/"
-	httpsPort := tlsLn.Addr().(*net.TCPAddr).Port
-	httpsEndpoint := "https://localhost:" + strconv.Itoa(httpsPort) + "/"
-
-	// start proxy
-	testProxy, err := NewProxy(&Options{
-		Addr:        ":29082", // some random port
-		SslInsecure: true,
-	})
-	handleError(t, err)
-	testProxy.AddAddon(&interceptAddon{})
-	testOrderAddonInstance := &testOrderAddon{
-		orders: make([]string, 0),
-	}
-	testProxy.AddAddon(testOrderAddonInstance)
 	go testProxy.Start()
 	time.Sleep(time.Millisecond * 10) // wait for test proxy startup
 
-	getProxyClient := func() *http.Client {
-		return &http.Client{
-			Transport: &http.Transport{
-				TLSClientConfig: &tls.Config{
-					InsecureSkipVerify: true,
-				},
-				Proxy: func(r *http.Request) (*url.URL, error) {
-					return url.Parse("http://127.0.0.1:29082")
-				},
-			},
-		}
-	}
-
 	t.Run("should not have eof error when server close connection immediately", func(t *testing.T) {
 		proxyClient := getProxyClient()
 		t.Run("http", func(t *testing.T) {